-
Notifications
You must be signed in to change notification settings - Fork 9
Ckan provider (WIP "kinda") #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… and there is not good working demo site inorder to test effectively.
| counter += 1000 | ||
| list_of_datasets.extend(results['results']) | ||
|
|
||
| return list_of_datasets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E271 multiple spaces after keyword
|
|
||
| return list_of_datasets | ||
|
|
||
| class CKANGeoService(CKANServiceBase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E302 expected 2 blank lines, found 1
| dataset_name = param.String(default="", doc="", precedence=2) | ||
| author = param.String(default="", doc="", precedence=3) | ||
| author_email = param.String(default="", doc="", precedence=4) | ||
| availability = param.ObjectSelector(default=None, doc="", objects=[True,False], precedence=5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E231 missing whitespace after ','
| type = param.String(default="", doc="Data type", precedence=7) | ||
| dataset = param_util.DatasetListSelector(default=(), filters={'status': 'downloaded'}, precedence=8, | ||
| doc="dataset to publish to ckan") | ||
| @property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E301 expected 1 blank line, found 0
| to loop. I then grab the next group of datasets, increment my counter, and then add it to | ||
| the list of other datasets. | ||
| """ | ||
| results = self.demo.action.package_search(**kwargs, start=0, rows=1000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E999 SyntaxError: invalid syntax
* Added the cuahsi coverage fix. The change was not getting all the resources and just getting all resources that had a coverage from the world. * Made kwargs the standard over using options, params, and kwargs. * Updated the load_providers to only update if update-cache is True or if the global is None.
… and there is not good working demo site inorder to test effectively.
… fixes the tests.
|
|
||
| providers = {name: driver.DriverManager('quest.services', name, invoke_on_load=True, invoke_kwds={'name': name}).driver for name in web_services} | ||
| if update_cache or the_providers is None: | ||
| providers = {name: driver.DriverManager('quest.services', name, invoke_on_load=True, invoke_kwds={'name': name}).driver for name in web_services} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (153 > 120 characters)
| if len(settings.get('USER_SERVICES', [])) > 0: | ||
| for uri in settings.get('USER_SERVICES', []): | ||
| try: | ||
| drv = driver.DriverManager('quest.services', 'user', invoke_on_load=True, invoke_kwds={'uri': uri}).driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (126 > 120 characters)
|
So I tired working on this plugin again, but there seems to be a lot of issues still going on with the Demo Site that they have here: https://demo.ckan.org/. If anyone knows of a CKAN site that you are able to grab data and push data too let me know. I haven't been able to find one that works correctly, or one that has the rest api turned on. Maybe for now we just focus on getting data from CKAN rather than trying to store data. |
|
Maybe we just need to stand up our own instance of CKAN. |
This is the provider plugin for Ckan. This plugin is working correctly, but there is no Ckan live site to test the upload correctly. Until we find a Ckan site that allows us to add resources or someone gets back to me on how to upload files correctly, then I think we should wait on this merge.